fix(registry): retire five plugin entries whose repositories are gone - #4153
fix(registry): retire five plugin entries whose repositories are gone#4153L4XB wants to merge 2 commits into
Conversation
`gh api repos/Schlaflied/career-ops-plugin-<id>` returns 404 for all five, so `validate-plugin-registry.mjs --deep` cannot clone them and the "Validate registry entries" check fails on every PR that touches `plugins-registry/**` — including PRs that have nothing to do with these entries. Removes the five registry files and their rows in `docs/PLUGINS.md`, so the published table and the registry keep saying the same thing. Nothing else references them: `CHANGELOG.md` is release-please output and records the historical additions, which stay accurate as history. The entries are retired rather than re-pointed because the repositories are not merely moved — the author's account and every one of the five repositories return 404, so there is no target to re-point at. Re-adding them later is the ordinary registration flow. Fixes career-ops-hq#4130
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe pull request removes five invalid plugin registrations and their documentation rows. It also changes the registry validation workflow to exclude deleted entries from the one-entry change limit. ChangesPlugin registry retirement
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The unavailable registrations and matching documentation rows are removed, while additions and modifications remain subject to the single-entry validation gate. 🚥 Pre-merge checks | ✅ 8 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (8 passed)
Full details: Agent-Operated Pr DisclosureExplanation The required PR identity metadata is unavailable. The review refs are detached and expose no source branch, and the repository has no PR label record. The head commit identifies Resolution Provide the PR source branch, GitHub author identity, and current labels. If the branch starts with ✨ Finishing Touches🧪 Generate unit tests (beta)
🚀 Post-Merge Actions
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The gate counted every changed `plugins-registry/*.json`, deletions
included, which made retiring dead entries impossible in either shape:
* As one PR — refused here, five files changed.
* Split into five — `--deep` clones every entry that is still present, so
each PR stays red until the last dead entry is gone. Every PR in the
series is red, including the last one before it merges.
`--diff-filter=AM` is what the refusal message already describes ("add or
bump"). Verified both ways against this branch: a deletion-only PR counts
0, and a control commit adding two entries still counts 2 and is refused.
Refs career-ops-hq#4130
|
Worth flagging because the two rules cannot both be satisfied while any dead entry exists, in either shape:
The second commit narrows the counter to If you would rather not take a CI change in a registry PR, say so and I will drop that commit — but then this issue needs the gate relaxed on your side first, because no shape of the fix can go green through it. |
1 participant
Fixes #4130.
What happened
gh api repos/Schlaflied/career-ops-plugin-<id>returns 404 for all five entries, sovalidate-plugin-registry.mjs --deepcannot clone them at their pinned SHAs and the Validate registry entries check fails on every PR that touchesplugins-registry/**— including PRs with nothing to do with these plugins.Verified again just now:
The change
The five registry files are removed, together with their rows in
docs/PLUGINS.md, so the published table and the registry keep saying the same thing.CHANGELOG.mdis release-please output and records the historical additions; those entries stay accurate as history and are left alone.Retired rather than re-pointed because the repositories are not merely moved: the author's account and all five repositories return 404, so there is no target to re-point at. Re-adding them later is the ordinary registration flow.
Evidence
The deep gate is the one the issue reports as failing, and it now passes on the four remaining entries.
That single failure (
--status prerequisite/score handling wrong) is pre-existing and unrelated:mainatbb641dc, checked out in a clean worktree with the same dependencies, reports exactly the same8724 passed, 1 failed. Test count is unchanged in both directions, so no assertion depended on these five entries.Summary
Retires five unavailable plugin registry entries. Removes their Community plugins table rows from
docs/PLUGINS.md:111-113.User impact
Users can no longer discover or register these unavailable plugins. Deep registry validation can pass for the remaining entries.
The one-plugin-per-PR check now counts only added or modified registry files. Deletions do not count, so retirement PRs can remove multiple unavailable entries. Adding or modifying more than one entry still fails at
.github/workflows/plugin-registry-validate.yml:62-70.System files
Changed:
.github/workflows/plugin-registry-validate.yml.Not changed:
AGENTS.md,modes/,update-system.mjs,DATA_CONTRACT.md, orproviders/.