fix: separated vestingSchedule#458
Conversation
separated vestingSchedule into cliffYears and vestingYears updated prisma tables for Share and Options to separate vestingSchedule into cliffYears and vestingYears with respectable trpc types and updated Shares and Options modal to separate vestingSchedule into two columns cliffYears and vestingYears
|
Thank you for following the naming conventions for pull request titles! 🙏 |
Alfredoeb9
changed the title
dahal
left a comment
dahal
left a comment
There was a problem hiding this comment.
Thanks for submitting this PR @Alfredoeb9.
There are some build errors
You can always make sure the build works by running pnpm build
fixed build errors, had to remove vestingSchedule from GET request on getSharesProcedure and getOptionsProcedure and replace with cliffYears and vestingYears
…oeb9/captable into separate-vesting-schedule
removed vestingSchedule at server level and replaced with cliffYears and vestingYears as vestingSchedule was separted into two fields
updated default value from empty string to 0 as default types for fields are numbers
dahal
left a comment
dahal
left a comment
There was a problem hiding this comment.
Looks like we have additional build errors @Alfredoeb9
https://github.com/captableinc/captable/actions/runs/10035838246/job/27732505821?pr=458
Alfredoeb9
force-pushed
the
separate-vesting-schedule
branch
from
c29f11a to
41e3560
Compare
|
Fixed build errors mentioned above and tested build and passed with npm build command and with docker compose up --build |
|
Getting inconsistent webpack build errors when running docker compose up nuking branch and setting up again
I nuked my local project and cloned again ran docker compose up and still received same webpack error as above. I nuked the local project again and cloned, I then reverted back one commit when I did not see webpack errors from screenshot, ran docker compose up and received same webpack error. I nuked the local project again and cloned, I then reverted back two commits when I did not see the webpack errors from screenshot, ran docker compose up and received same webpack error. With these findings i'm not sure what could have caused the error on screenshot. |
|
After updating docker application, I am no longer seeing random webpack errors and application is running as expected locally. Successful build on pnpm build and docker compose up --build |
Alfredoeb9
left a comment
Alfredoeb9
left a comment
There was a problem hiding this comment.
Review Completed
…chedule fix: separated vestingSchedule
2 participants
Issue
Issue: #454
Description
separated vestingSchedule into cliffYears and vestingYears
updated prisma tables for Share and Options to separate vestingSchedule into cliffYears and vestingYears with respectable trpc types and updated Shares and Options modal to separate vestingSchedule into two columns cliffYears and vestingYears