feat: update profile #150
Merged
dahal merged 27 commits intoMar 1, 2024
Merged
Conversation
|
Thank you for following the naming conventions for pull request titles! 🙏 |
Raju-kadel-27
changed the title
Contributor
Author
|
@dahal @chetannn I think it's ready for review. |
ghost
reviewed
Feb 29, 2024
| where: { | ||
| status: "ACTIVE", | ||
| id: user.memberId, | ||
| companyId: user.companyId, |
There was a problem hiding this comment.
filtering by companyId is not necessary here.
ghost
reviewed
Feb 29, 2024
| FormLabel, | ||
| FormMessage, | ||
| } from "@/components/ui/form"; | ||
| const profileSettingsSchema = z.object({ |
There was a problem hiding this comment.
Move this schema to a dedicated file so that it can be used on the backend as well.
ghost
reviewed
Feb 29, 2024
| const [file, setFile] = useState<File | null>(null); | ||
| const fileInputRef = useRef<HTMLInputElement>(null); | ||
|
|
||
| // @ts-expect-error: xxxx |
ghost
reviewed
Feb 29, 2024
| resolver: zodResolver(profileSettingsSchema), | ||
| }); | ||
|
|
||
| // @ts-expect-error: xxxx |
ghost
reviewed
Feb 29, 2024
| }, | ||
| }); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I think we need to fetch data initially from the server component and pass the profile as prop. useEffect is redundant here.
ghost
reviewed
Feb 29, 2024
| } | ||
| }, [memberProfile?.data, form]); | ||
|
|
||
| const handleImageUpload = async ( |
ghost
reviewed
Feb 29, 2024
| const handleFileChange = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
| const files = event.target.files; | ||
|
|
||
| if (files?.[0]) { |
There was a problem hiding this comment.
Extract the file validation logic to a utils.
ghost
reviewed
Feb 29, 2024
| const handleRemoveAvatar = () => { | ||
| setFile(null); | ||
| }; | ||
| async function onSubmit(values: z.infer<typeof profileSettingsSchema>) { |
There was a problem hiding this comment.
Changing a profile picture and saving profile information are two different actions like I said the day before. Clicking on save button should only save the profile information.
ghost
reviewed
Feb 29, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I have requested for some changes. Awesome work BTW
Contributor
Author
|
@chetannn I think I fixed the requested changes ?? |
ghost
approved these changes
Mar 1, 2024
zeekay
pushed a commit
to hanzoai/captable
that referenced
this pull request
Mar 10, 2026
* feat:update-profile-procedure * feat:zod schema for update profile input * feat: get-user-profile-procedure * feat: edit-profile-page * update to update-profile-procedures * get-profile-procedure updated * member-router schema update * env changes * new routers registered in root member router * session-sync-with-profile-update * update: profile-page * update: procedure-upatate-profile * update: schema-member-router * update: server/auth * minor fix * feat: added bucketMode props to s3 uploader * minor fix * minor change in payload-action-type enum * types * added zod-schemas * fix: member-router-schema * update: profile-page * update: update-profile-procedure * added enum in constants * update * update * update utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for issue #139