fix: undefined values in audit logs while revoking invite#109
Merged
Conversation
|
Thank you for following the naming conventions for pull request titles! 🙏 |
zeekay
pushed a commit
to hanzoai/captable
that referenced
this pull request
Mar 10, 2026
…c#109) * refactor: invite member procedure * feat: split context and extract type * refactor: split procedure into handler * refactor: accept member procedure * refactor: revoke invite procedure * refactor: remove member procedure * refactor: deactivate user procedure * refactor: update member procedure * refactor: invite member procedure * refactor: reinvite procedure * refactor: get members procedure * refactor: move inside procedure folder * chore: remove unused code * refactor: logic inside removeMemberProcedure * feat: use refactored code * feat: revoke invite * feat: order stakeholders by name --------- Co-authored-by: Puru Dahal <dahal@users.noreply.github.com> Co-authored-by: Puru D <puru@dahal.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reason for the
undefinedvalues while revoking members is because of the race condition betweenrevokeInviteandremoveMemberprocedures and how we conditionally mutate from the frontend. This PR aims to refactor the procedures into separate files and decouple the logic, making it callable within another procedure.changes done
stakeholder routerto separate files inside procedures folderremoveMemberProcedureremoveMemberProcedureinsiderevokeInviteProcedureMemberCard componentwhich is a dead codebefore:
after: