Skip to content

ec2 _find_image_serial: support serials in YYYYMMDD.n format (SC-1182) #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucasmoura merged 1 commit into from
Jul 14, 2022
Merged

ec2 _find_image_serial: support serials in YYYYMMDD.n format (SC-1182) #207

lucasmoura merged 1 commit into from
Jul 14, 2022
+1 −1

Conversation

@paride
Copy link
Collaborator

@paride paride commented Jul 13, 2022

No description provided.

@paride paride requested a review from lucasmoura July 13, 2022 13:11
@paride
Copy link
Collaborator Author

paride commented Jul 13, 2022

I was pretty sure I explicitly tested support for .n serials, but apparently I didn't.

@paride paride changed the title ec2 _find_image_serial: support serials in YYYYMMDD.n format ec2 _find_image_serial: support serials in YYYYMMDD.n format (SC-1182) Jul 13, 2022
@paride
Copy link
Collaborator Author

paride commented Jul 13, 2022

CI failure looks unrelated:

$ sudo snap install lxd

error: cannot perform the following tasks:

- Start snap "lxd" (23270) services (systemctl command [start snap.lxd.activate.service] failed with exit status 1: Job for snap.lxd.activate.service failed because the control process exited with error code.

See "systemctl status snap.lxd.activate.service" and "journalctl -xe" for details.

)

The command "sudo snap install lxd" exited with 1.

@paride
Copy link
Collaborator Author

paride commented Jul 13, 2022

CI passed with a no-change retrigger.

@paride
Copy link
Collaborator Author

paride commented Jul 13, 2022

@lucasmoura at the moment ami-08fb9772db27d3d4a on us-east-2 has serial 20220712.1, if you want to test this live.

lucasmoura
lucasmoura reviewed Jul 13, 2022
View reviewed changes
@paride paride force-pushed the ec2-support-dot-serials branch from 27b859b to 0a3d93c Compare July 14, 2022 09:34
@paride paride requested a review from lucasmoura July 14, 2022 09:35
@lucasmoura lucasmoura merged commit c6b0175 into canonical:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lucasmoura lucasmoura lucasmoura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paride @lucasmoura