lxd: do not restart instances via stop+start (SC-1112) #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ephemeral instanced do not survive being stopped, while they do survive being restarted.
paride
force-pushed
the
lxd-fix-ephemeral-restart
branch
from
f60357f to
ec561f0
Compare
paride
changed the title
Collaborator
Author
|
Doing stop/start is causing issues in the bootspeed measurements, which use ephemeral instances. |
TheRealFalcon
approved these changes
Jun 20, 2022
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Looks good, but we may need to come back and change this to only call restart for ephemeral instances while calling stop/start for "regular" instances depending on if LXD VM failures come back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ephemeral instanced do not survive being stopped, while they do survive
being restarted.