Ubuntu/bionic: fix lintian #1566
Conversation
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Minor pending discussion on #1563 which applies here.
Fixed, ready to be reviewed. |
|
|
||
| # Don't do anything unless we have grub | ||
| [ -x /usr/sbin/grub-install ] || return 0 | ||
| command -v grub-install > /dev/null 2>&1 || return 0 |
There was a problem hiding this comment.
Nit: no need to redirect stderr.
There was a problem hiding this comment.
Looks like you're still redirecting stderr (2>&1)? Anyway this is really a nitty nit, up to you what to do here!
| @@ -0,0 +1,2 @@ | |||
| # Conflict due to Ubuntu version conventions | |||
| cloud-init source: binary-nmu-debian-revision-in-source | |||
There was a problem hiding this comment.
This looks like a bug in Lintian. Lintian shouldn't issue that warning on Ubuntu packages, see the && !$ubuntu here:
I think the issue is with this regexp:
but I didn't dig too deep. Ideally we should file a bug against lintian and refer to bug number in the explanatory comment.
There was a problem hiding this comment.
I've commented on the lintian bug as well. I think we can discuss as a team whether to change or diminished version ~18.04.1 vs. augmented version strategy .18.04.1 even though I feel like this is a lintian versioning bug. Since we are now appending the Ubuntu development version suffix for all releases in kinetic, changing to the augmented .22.04.1 suffix for jammy would still preserve a package version upgrade path to kinetic's comparable suffix .22.10.1.
|
Converted to draft to solve @paride's comments: |
Fix command-with-path-in-maintainer-script for grub-install.
silence binary-nmu-debian-revision-in-source bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014584
aciba90
left a comment
aciba90
left a comment
There was a problem hiding this comment.
Thanks, @paride, for pointing the lintian bug out. I have filled a bug report and referenced it in the changelog.
|
|
||
| # Don't do anything unless we have grub | ||
| [ -x /usr/sbin/grub-install ] || return 0 | ||
| command -v grub-install > /dev/null 2>&1 || return 0 |
| @@ -0,0 +1,2 @@ | |||
| # Conflict due to Ubuntu version conventions | |||
| cloud-init source: binary-nmu-debian-revision-in-source | |||
|
|
||
| # Don't do anything unless we have grub | ||
| [ -x /usr/sbin/grub-install ] || return 0 | ||
| command -v grub-install > /dev/null 2>&1 || return 0 |
There was a problem hiding this comment.
Looks like you're still redirecting stderr (2>&1)? Anyway this is really a nitty nit, up to you what to do here!
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
- build-package, sbuild success lintian warnings reduced
- d/changelog package version good, changelog entries good
- separate commits for debian/* changes good
- +1 on travis CI to focal
- will discuss versioning suffix changes ~18.04.1 -> .18.04.1 separately.
3 participants
do not squash
SC-1154