tox: integration-tests-jenkins: softfail if only some test failed (SC-1117) #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change a single test failure when running the integration-tests-jenkins tox environment caused Jenkins jobs to fully fail (status FAILURE). With this change the pytest's "some tests failed" return code [1] is ignored, and the status of the Jenkins jobs is determined using the junit report that pytest generates. Most of the time this will result in UNSTABLE (yellow) jobs when some tests failed. If the junit report is missing (or only reports failures) the job will still be marked as FAILURE (red). [1] https://docs.pytest.org/en/7.1.x/reference/exit-codes.html
Contributor
Author
|
This should help distinguish tests failure from infrastructure/Jenkint/network/... issues. If you're wondering where we're telling pytest to generate the junit report it's here: https://github.com/canonical/server-jenkins-jobs/blob/4871903be5d8f411f7fe1b2cb0e7b8ff754e69fa/jenkins-jobs/cloud-init/integration.yaml#L167=. |
paride
changed the title
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
See the internal Jenkins
cloud-initview.Test Steps
integration-tests-jenkinson a subsetof tests containing it. Verify that tox logs the failure but returns 0.
Verify that tox returns nonzero (should return 4 iirc).
Checklist: