Skip to content

Conversation

@asanvaq
Copy link
Contributor

@asanvaq asanvaq commented Nov 11, 2025

The index items explanation and reference have been rearranged to match the homepage template.

@asanvaq asanvaq changed the title Rearranging home page index ROCKS-2627 Rearranging home page index Nov 11, 2025
@asanvaq asanvaq changed the title ROCKS-2627 Rearranging home page index Rearranging home page index Nov 11, 2025
@asanvaq asanvaq marked this pull request as ready for review November 11, 2025 16:29
Copy link

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compared the PR build with the latest live docs. lgtm +1

@lczyk
Copy link

lczyk commented Nov 12, 2025

minor nitpick re title. try using conventional commits to make the commit titles a little bit more machine-readable and standardized. in this case i'd make the title docs: rearranging home page index.

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

I'll merge and re-write the commit to be conventional and capture the changes (which also include refactoring of the security reference)

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, before I merge, we need all commits to be signed @asanvaq . Ping me if you need help doing that ;)

The index items explanation and reference have been rearranged to match the homepage template.
@asanvaq asanvaq force-pushed the index-rearranging branch 2 times, most recently from b74f12e to c0f1924 Compare November 24, 2025 11:09
@asanvaq asanvaq marked this pull request as draft November 24, 2025 11:09
Signed-off-by: Anna Sancho Vaquer <anna.sanchovaquer@canonical.com>
Signed-off-by: Anna Sancho Vaquer <anna.sanchovaquer@canonical.com>
Signed-off-by: Anna Sancho Vaquer <anna.sanchovaquer@canonical.com>
@asanvaq asanvaq marked this pull request as ready for review November 27, 2025 15:08
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ;)

@cjdcordeiro cjdcordeiro merged commit eb1a859 into canonical:main Nov 27, 2025
4 checks passed
@asanvaq asanvaq deleted the index-rearranging branch November 27, 2025 15:15
@rkratky rkratky mentioned this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants