-
Notifications
You must be signed in to change notification settings - Fork 10
Rearranging home page index #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lczyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compared the PR build with the latest live docs. lgtm +1
|
minor nitpick re title. try using conventional commits to make the commit titles a little bit more machine-readable and standardized. in this case i'd make the title |
cjdcordeiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
I'll merge and re-write the commit to be conventional and capture the changes (which also include refactoring of the security reference)
cjdcordeiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, before I merge, we need all commits to be signed @asanvaq . Ping me if you need help doing that ;)
The index items explanation and reference have been rearranged to match the homepage template.
b74f12e to
c0f1924
Compare
Signed-off-by: Anna Sancho Vaquer <anna.sanchovaquer@canonical.com>
Signed-off-by: Anna Sancho Vaquer <anna.sanchovaquer@canonical.com>
Signed-off-by: Anna Sancho Vaquer <anna.sanchovaquer@canonical.com>
cjdcordeiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks ;)
The index items explanation and reference have been rearranged to match the homepage template.