slicer/test: Define all release archives #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the slicer test defines one archive named "ubuntu" for all test cases no matter what they define in chisel.yaml. But since commit afad3d2 we allow more archives with different names to be defined in chisel.yaml. Define a test archive for each of them.
cjdcordeiro
requested review from
rebornplusplus
and removed request for
rebornplusplus
rebornplusplus
approved these changes
Aug 24, 2023
| result: map[string]string{ | ||
| "/usr/": "dir 0755", | ||
| "/usr/bin/": "dir 0755", | ||
| "/usr/bin/hello": "file 0775 eaf29575", |
There was a problem hiding this comment.
Out of curiosity, how did you know the checksum of the /usr/bin/hello here?
Contributor
Author
There was a problem hiding this comment.
It is the same file from the embedded base-files package, so I've just copied it from the result maps from earlier test cases.
niemeyer
approved these changes
Aug 28, 2023
Contributor
niemeyer
left a comment
niemeyer
left a comment
There was a problem hiding this comment.
It's been a while so it's unclear to me how the default archive logic is mixing with the most recent package version logic. With that said, this PR is simply improving tests, so it can only be a good thing so I'm merging it. Let's please sync about this in a future conversation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the slicer test defines one archive named "ubuntu" for all
test cases no matter what they define in chisel.yaml. But since commit
afad3d2 we allow more archives with different names to be defined in
chisel.yaml. Define a test archive for each of them.