Skip to content

Conversation

@zhijie-yang
Copy link
Contributor

  • Have you signed the CLA?

  • This PR bumps the Golang version to 1.22 to fix the known exploited vulnerabilities (CVE-2024-34158 and CVE-2024-34156, and CVE-2024-34155, which is a medium vulnerability not listed as a KEV) in Golang v1.21.

  • To accommodate the bumped Golang version, the golangci-lint is bumped to v1.63.4.

  • The PR bumping Golang to v1.23 chore(deps): bump Golang to v1.23 #198 is dropped since the latest Ubuntu LTS (noble) does not officially support v1.23, which resulted in additional changes in building and testing the project.

@zhijie-yang zhijie-yang marked this pull request as ready for review January 29, 2025 10:55
@zhijie-yang zhijie-yang requested a review from letFunny January 29, 2025 10:56
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Copy link

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some risk we may have to roll this back depending on where Chisel is being built at the moment. Let's take the risk and see what happens.

@niemeyer niemeyer merged commit d09c132 into canonical:main Feb 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants