feat: add performance testing in the ci #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
letFunny
commented
Jan 24, 2025
letFunny
commented
- Have you signed the CLA?
Collaborator
Author
|
We have to configure the repo to have the correct permissions in "Settings". It works in mine out of the box: letFunny#26. Probably not sending write permissions with the GITHUB_TOKENS to PRs from forks. EDIT: Should work out of the box, just tested it in another repo. |
niemeyer
approved these changes
Feb 4, 2025
Contributor
niemeyer
left a comment
niemeyer
left a comment
There was a problem hiding this comment.
Nice. Just trivial detail and LGTM.
.github/workflows/performance.yaml
Outdated
| benchmark-info: | ||
| runs-on: ubuntu-22.04 | ||
| needs: build | ||
| name: Benchmark chisel info (24.04) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.