feat: add support for "v2-archives" in "v1" format #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"v2-archives" is used for backwards compatibility with Chisel <= 1.0.0 since it will be ignored. In new versions, it will be parsed with the new fields that break said compatibility, e.g. "pro" archives.
niemeyer
approved these changes
Dec 13, 2024
Contributor
niemeyer
left a comment
niemeyer
left a comment
There was a problem hiding this comment.
Looks good, thank you! The only detail that needs tuning is the comment, as outlined below:
| // since it will be ignored. In new versions, it will be parsed with the new | ||
| // fields that break said compatibility, e.g. "pro" archives. | ||
| // | ||
| // Note: "archives" and "v2-archives" are merged together while parsing. |
Contributor
There was a problem hiding this comment.
The comment needs tuning as it's currently saying that it will both be ignored, in the very first sentence, and it will be merged together, at the end. It needs to s/v1.0.0 since/v1.0.0, where/, or similar.
Contributor
|
Since this PR is high priority, and the only detail is in the comment, I'm merging it right away. Let's please fix the comment in a forthcoming PR. |
cjdcordeiro
pushed a commit
to cjdcordeiro/chisel
that referenced
this pull request
Dec 16, 2024
"v2-archives" is used for backwards compatibility with Chisel <= 1.0.0 since it will be ignored. In new versions, it will be parsed with the new fields that break said compatibility, e.g. "pro" archives. Co-authored-by: Rafid Bin Mostofa <rafid.mostofa@canonical.com>
cjdcordeiro
pushed a commit
to cjdcordeiro/chisel
that referenced
this pull request
Dec 16, 2024
"v2-archives" is used for backwards compatibility with Chisel <= 1.0.0 since it will be ignored. In new versions, it will be parsed with the new fields that break said compatibility, e.g. "pro" archives. Co-authored-by: Rafid Bin Mostofa <rafid.mostofa@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"v2-archives" is used for backwards compatibility with Chisel <= 1.0.0 since it will be ignored. In new versions, it will be parsed with the new fields that break said compatibility, e.g. "pro" archives.