Skip to content

refactor(setup): move YAML-specific logic to yaml.go #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
niemeyer merged 3 commits into from
Nov 22, 2024
Merged

refactor(setup): move YAML-specific logic to yaml.go #169

niemeyer merged 3 commits into from
Nov 22, 2024

Conversation

@letFunny
Copy link
Collaborator

@letFunny letFunny commented Oct 24, 2024

  • Have you signed the CLA?

@letFunny letFunny added Simple Nice for a quick look on a minute or two Polish Refactorings, etc labels Oct 24, 2024
@letFunny
Copy link
Collaborator Author

letFunny commented Oct 24, 2024

Verified that we are only moving code by using git diff --color-moved HEAD~.

niemeyer
niemeyer approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reorg!

@niemeyer niemeyer merged commit b45d61f into canonical:main Nov 22, 2024
14 checks passed
@letFunny letFunny deleted the move-yaml-to-file branch January 21, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niemeyer niemeyer niemeyer approved these changes

Assignees

No one assigned

Labels

Polish Refactorings, etc Simple Nice for a quick look on a minute or two

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@letFunny @niemeyer