fix: explicit parents override implicit #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letFunny
added
Bug
rebornplusplus
left a comment
rebornplusplus
left a comment
There was a problem hiding this comment.
Looks nice, thanks. Left a couple of comments.
rebornplusplus
approved these changes
Oct 24, 2024
rebornplusplus
left a comment
rebornplusplus
left a comment
There was a problem hiding this comment.
Looks good to me, thank you! :)
niemeyer
approved these changes
Nov 11, 2024
Contributor
niemeyer
left a comment
niemeyer
left a comment
There was a problem hiding this comment.
Thanks for the fix. One suggestion only, optional.
niemeyer
changed the title
Contributor
|
Side note: the summary prefix is "fix", not "bugfix". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits introduces a new flag for
fsutil.CreatecalledOverrideModewhich updates the mode of existing entries. It is used to ensure that the explicit folder overrides the permissions of the implicit ones.