Skip to content

refactor: tune error message for invalid generate value #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
niemeyer merged 1 commit into from
Oct 7, 2024
Merged

refactor: tune error message for invalid generate value #162

niemeyer merged 1 commit into from
Oct 7, 2024

Conversation

@letFunny
Copy link
Collaborator

@letFunny letFunny commented Oct 4, 2024

  • Have you signed the CLA?

@letFunny letFunny added the Simple Nice for a quick look on a minute or two label Oct 4, 2024
@rebornplusplus rebornplusplus mentioned this pull request Oct 4, 2024
Closed
niemeyer
niemeyer approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@niemeyer niemeyer merged commit 406881b into canonical:main Oct 7, 2024
@letFunny letFunny deleted the remove-consider-updating-message branch October 17, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niemeyer niemeyer niemeyer approved these changes

+1 more reviewer

@rebornplusplus rebornplusplus rebornplusplus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Simple Nice for a quick look on a minute or two

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@letFunny @niemeyer @rebornplusplus