fix: package names can be of length two #120
Conversation
rebornplusplus
changed the title
rebornplusplus
force-pushed
the
fix/package-name-length
branch
from
a195268 to
0701528
Compare
This commit adds support for package names with a minimum length of two. Previously chisel only supported a minimum length of 3. The limit on the slice name is kept unchanged. Fixes canonical#119.
letFunny
left a comment
letFunny
left a comment
There was a problem hiding this comment.
Can you link the naming requirements for debian packages if you have them? I want to see them to check the tests + regexp.
|
If this is the correct definition (copied from the issue):
Then "a-", "a+" and "a." are valid names not captured by the regexp. |
I only have that reference for now. I am planning to go through the Debian Policy Manual again, today. But yes, based on the definition above, you should be right. But I am not sure if |
|
So yeah, the current regex does support package names like There are packages like I didn't find occurrences like |
Add pkg and slice name expression string variables to remove duplication and increase test coverage.
rebornplusplus
changed the title
|
It would be nice if this could be merged soon :) I have some weird hacks to get a static |
This reverts commit 0f724ae.
letFunny
left a comment
letFunny
left a comment
There was a problem hiding this comment.
I still think some way of tying the three regexps together would be nice (#120 (comment)) but let's keep it simple for this bugfix.
|
|
||
| var fnameExp = regexp.MustCompile(`^([a-z0-9](?:-?[.a-z0-9+]){2,})\.yaml$`) | ||
| // fnameExp matches the slice definition file basename. | ||
| var fnameExp = regexp.MustCompile(`^([a-z0-9](?:-?[.a-z0-9+]){1,})\.yaml$`) |
There was a problem hiding this comment.
Sorry for missing this earlier, but why do we have a dot (.) in that second group? That doesn't look right.
Same question below.
niemeyer
left a comment
niemeyer
left a comment
There was a problem hiding this comment.
Let's actually go ahead with this for now. Alberto just pointed out that this is part of the package rules, and this is already in the code, so arguably an independent issue.
Let's please follow up on it, though, and agree on the path forward.
5 participants
This PR adds support for package names with a minimum length of two. Previously chisel only supported a minimum length of 3. The limit on the slice name is kept unchanged.
Fixes #119.