Skip to content

fix starlark link #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjdcordeiro merged 1 commit into from
Jan 4, 2024
Merged

fix starlark link #110

cjdcordeiro merged 1 commit into from
Jan 4, 2024

Conversation

@shyim
Copy link
Contributor

@shyim shyim commented Dec 27, 2023 •
edited
Loading

  • Have you signed the CLA?

@letFunny
Copy link
Collaborator

letFunny commented Jan 2, 2024

Hi @shyim, I can see that no files were changes in your commit, is that intentional?

@shyim
Copy link
Contributor Author

shyim commented Jan 2, 2024

whoopsie. fixed. :)

letFunny
letFunny approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

rebornplusplus
rebornplusplus approved these changes Jan 4, 2024
View reviewed changes
Copy link

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@rebornplusplus rebornplusplus added the Simple Nice for a quick look on a minute or two label Jan 4, 2024
@cjdcordeiro cjdcordeiro self-assigned this Jan 4, 2024
@shyim
Copy link
Contributor Author

shyim commented Jan 4, 2024

When you rerun the CLA check it should be fine then
image

@cjdcordeiro
Copy link
Collaborator

cjdcordeiro commented Jan 4, 2024

Thanks. I'm merging it since it's a doc-related simple fix.

@cjdcordeiro cjdcordeiro merged commit 48aa6ee into canonical:main Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rebornplusplus rebornplusplus rebornplusplus approved these changes

@letFunny letFunny letFunny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cjdcordeiro cjdcordeiro

Labels

Simple Nice for a quick look on a minute or two

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shyim @letFunny @cjdcordeiro @rebornplusplus