fprintd should enroll a user, not a uid (BugFix) #813
Conversation
Codecov Report
@@ Coverage Diff @@
## main #813 +/- ##
=======================================
Coverage 35.25% 35.25%
=======================================
Files 302 302
Lines 34173 34173
Branches 5907 5907
=======================================
Hits 12048 12048
Misses 21559 21559
Partials 566 566
Flags with carried forward coverage won't be shown. Click here to find out more. |
binli
force-pushed
the
fprintd-uid
branch
4 times, most recently
from
e352a03 to
b5a58ef
Compare
|
/canonical/self-hosted-runners/run-workflows b5a58ef |
pieqq
changed the title
|
/canonical/self-hosted-runners/run-workflows bf2d4f3 |
|
@pieqq hi, the title sounds good in my side, do you know why the failure of 'PR Validation'? Thanks! $ echo "fprintd should enroll a user, not a uid (BugFix)" | grep -iP "((infra|bugfix|new|breaking))$" |
$ sudo env | grep SUDO SUDO_COMMAND=/usr/bin/env SUDO_USER=ubuntu SUDO_UID=1001 SUDO_GID=1001 when running checkbox with sudo, it will 'fprintd-enroll 1001' and the test case will lock screen to let 'ubuntu' user to login, but at that time, it will not work because the user is not 'ubuntu'.
|
/canonical/self-hosted-runners/run-workflows bf2d4f3 |
|
It's because we use self-hosted runners and they require some manual steps from people in the Cert team when someone submits their first PR... It should be fixed now. I tried your PR with a laptop, but I couldn't get the fingerprint tests to work. I'll check again with another laptop tomorrow. Quick question, what do you mean when you say "when running checkbox with sudo"? Do you run |
|
@pieqq Oh, got it, thanks! And we met this issue when QA do finger printer test by manual, I need confirm with @eugene-yujinwu . |
|
@pieqq With this patch, the result will be good. |
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
From the look of it and the outcome provided, it looks all good. Sorry for the long delay in approving this!
fprintd should enroll to a user while not uid. (BugFix) (canonical#813) $ sudo env | grep SUDO SUDO_COMMAND=/usr/bin/env SUDO_USER=ubuntu SUDO_UID=1001 SUDO_GID=1001 when running checkbox with sudo, it will 'fprintd-enroll 1001' and the test case will lock screen to let 'ubuntu' user to login, but at that time, it will not work because the user is not 'ubuntu'.
fprintd should enroll to a user while not uid. (BugFix) (canonical#813) $ sudo env | grep SUDO SUDO_COMMAND=/usr/bin/env SUDO_USER=ubuntu SUDO_UID=1001 SUDO_GID=1001 when running checkbox with sudo, it will 'fprintd-enroll 1001' and the test case will lock screen to let 'ubuntu' user to login, but at that time, it will not work because the user is not 'ubuntu'.
3 participants
$ sudo env | grep SUDO
SUDO_COMMAND=/usr/bin/env
SUDO_USER=ubuntu
SUDO_UID=1001
SUDO_GID=1001
when running checkbox with sudo, it will 'fprintd-enroll 1001' and the test case will lock screen to let 'ubuntu' user to login, but at that time, it will not work because the user is not 'ubuntu'.
Description
Resolved issues
Documentation
Tests