Skip to content

Commit 64ea166

Browse files
committed
Modify the wwan related test cases.
The mobilebroadband-cert-automated test case is only part of the wwan test plan. We hope to replace mobilebroadband-cert-automated with wwan-automated. The relevant test plans we currently use include: client-cert-desktop-22-04-automated client-cert-desktop-20-04-automated client-cert-desktop-18-04-automated I have replaced mobilebroadband-cert-automated in them with wwan-automated, and added after-sudpend-wwan- automated to ensure that wwan is tested before and after suspend. In addition, for mobilebroadband-cert-manual in the Manual test plan, when the SIM is inserted into the prototype in the desktop, the system should automatically recognize wwan and SIM card, and we do not need to perform manual testing. So I deleted mobilebroadband-cert-manual in the relevant test plans. At the same time, since wwan-automated already contains wwan-manual cases, I deleted the wwan-manual in these test plans: client-cert-desktop-22-04-manual client-cert-desktop-20-04-manual client-cert-desktop-18-04-manual
1 parent 03ea2ce commit 64ea166

File tree

5 files changed

+6
-81
lines changed

5 files changed

+6
-81
lines changed

providers/base/units/wwan/jobs.pxu

Lines changed: 0 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -116,58 +116,6 @@ category_id: wwan
116116
requires:
117117
manifest.has_wwan_module == 'True'
118118

119-
id: wwan/check-sim-present-manual
120-
plugin: manual
121-
_summary: Check if a SIM card is present in a slot connected to the modem
122-
_purpose:
123-
Check if a SIM card is present in a slot connected to the modem
124-
_steps:
125-
1. Open another terminal on SUT (or press ctrl+z to suspend Checkbox)
126-
2. Run `sudo mmcli -m 0 |grep SIM
127-
3. Run `fg` to jump back to checkbox (if you're running in the same terminal)
128-
_verification:
129-
Check the output. Was the SIM information printed?
130-
estimated_duration: 60s
131-
flags: also-after-suspend
132-
imports: from com.canonical.plainbox import manifest
133-
category_id: wwan
134-
requires:
135-
manifest.has_wwan_module == 'True'
136-
depends:
137-
wwan/detect-manual
138-
139-
id: wwan/gsm-connection-manual
140-
plugin: manual
141-
template-engine: jinja2
142-
_summary: Verify a GSM broadband modem can create a data connection
143-
_purpose:
144-
Ensure that the data connection can be made
145-
_steps:
146-
1. Open another terminal on SUT (or press ctrl+z to suspend Checkbox)
147-
2. Run `sudo nmcli c add type gsm ifname {{ __checkbox_env__.get("WWAN_CONTROL_IF", "<device name>") }} con-name GSM apn {{ __checkbox_env__.get("WWAN_APN", "<your.carrier.com>") }}`
148-
{%- if "WWAN_CONTROL_IF" not in __checkbox_env__ %}
149-
Replacing the <your.carrier.com> with appropriate APN name,
150-
and <device name> with appropriate device (device can be found by
151-
running sudo nmcli d)
152-
{%- endif %}
153-
{%- if "WWAN_NET_IF" not in __checkbox_env__ %}
154-
3. Ping Google (Run: `ping -I <ifname> 8.8.8.8 -c 5`)
155-
{%- else %}
156-
3. Ping Google (Run: `ping -I {{ __checkbox_env__.get("WWAN_NET_IF") }} 8.8.8.8 -c 5`)
157-
{%- endif %}
158-
4. Disconnect from the network (Run: `sudo nmcli c delete GSM`)
159-
5. Run `fg` to jump back to checkbox (if you're running in the same terminal)
160-
_verification:
161-
Did the ping came back?
162-
estimated_duration: 120s
163-
flags: also-after-suspend
164-
category_id: wwan
165-
imports: from com.canonical.plainbox import manifest
166-
requires:
167-
manifest.has_wwan_module == 'True'
168-
depends:
169-
wwan/check-sim-present-manual
170-
171119
id: wwan/scan-networks-manual
172120
plugin: manual
173121
_summary: Verify that modem can scan for available networks

providers/base/units/wwan/test-plan.pxu

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -39,25 +39,3 @@ include:
3939
after-suspend-wwan/gsm-connection-.*-auto
4040
bootstrap_include:
4141
wwan_resource
42-
43-
id: wwan-manual
44-
unit: test plan
45-
_name: Manual wwan tests
46-
_description: Manual wwan tests for Snappy Ubuntu Core devices
47-
include:
48-
wwan/detect-manual
49-
wwan/gsm-connection-manual
50-
wwan/check-sim-present-manual
51-
wwan/scan-networks-manual
52-
wwan/gsm-connection-interrupted-manual
53-
54-
id: after-suspend-wwan-manual
55-
unit: test plan
56-
_name: Manual wwan tests (after suspend)
57-
_description: Manual wwan tests for Snappy Ubuntu Core devices
58-
include:
59-
after-suspend-wwan/detect-manual
60-
after-suspend-wwan/gsm-connection-manual
61-
after-suspend-wwan/check-sim-present-manual
62-
after-suspend-wwan/scan-networks-manual
63-
after-suspend-wwan/gsm-connection-interrupted-manual

providers/certification-client/units/client-cert-desktop-18-04.pxu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ nested_part:
3434
misc-client-cert-manual
3535
mediacard-cert-manual
3636
memory-manual
37-
mobilebroadband-cert-manual
3837
ethernet-cert-manual
3938
networking-cert-manual
4039
optical-cert-manual
@@ -104,7 +103,7 @@ nested_part:
104103
mediacard-cert-automated
105104
mediacard-automated
106105
memory-automated
107-
mobilebroadband-cert-automated
106+
wwan-automated
108107
ethernet-cert-automated
109108
networking-cert-automated
110109
optical-cert-automated
@@ -129,6 +128,7 @@ nested_part:
129128
after-suspend-touchscreen-cert-automated
130129
after-suspend-wireless-cert-automated
131130
after-suspend-bluetooth-cert-automated
131+
after-suspend-wwan-automated
132132
# The following tests should run BEFORE the automated tests. The reboot and
133133
# power off tests will also give us a clean system to start the stress run
134134
# with.

providers/certification-client/units/client-cert-desktop-20-04.pxu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ nested_part:
3737
led-cert-manual
3838
mediacard-cert-manual
3939
memory-manual
40-
mobilebroadband-cert-manual
4140
ethernet-cert-manual
4241
networking-cert-manual
4342
optical-cert-manual
@@ -107,7 +106,7 @@ nested_part:
107106
mediacard-cert-automated
108107
mediacard-automated
109108
memory-automated
110-
mobilebroadband-cert-automated
109+
wwan-automated
111110
ethernet-cert-automated
112111
networking-cert-automated
113112
optical-cert-automated
@@ -132,6 +131,7 @@ nested_part:
132131
after-suspend-touchscreen-cert-automated
133132
after-suspend-wireless-cert-automated
134133
after-suspend-bluetooth-cert-automated
134+
after-suspend-wwan-automated
135135
# The following tests should run BEFORE the automated tests. The reboot and
136136
# power off tests will also give us a clean system to start the stress run
137137
# with.

providers/certification-client/units/client-cert-desktop-22-04.pxu

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ nested_part:
3737
led-cert-manual
3838
mediacard-cert-manual
3939
memory-manual
40-
mobilebroadband-cert-manual
4140
ethernet-cert-manual
4241
networking-cert-manual
4342
optical-cert-manual
@@ -112,7 +111,7 @@ nested_part:
112111
mediacard-cert-automated
113112
mediacard-automated
114113
memory-automated
115-
mobilebroadband-cert-automated
114+
wwan-automated
116115
ethernet-cert-automated
117116
networking-cert-automated
118117
optical-cert-automated
@@ -137,7 +136,7 @@ nested_part:
137136
after-suspend-cpu-cert-automated
138137
after-suspend-input-cert-automated
139138
after-suspend-disk-cert-automated
140-
after-suspend-mobilebroadband-cert-automated
139+
after-suspend-wwan-automated
141140
after-suspend-ethernet-cert-automated
142141
after-suspend-networking-cert-automated
143142
after-suspend-optical-cert-automated

0 commit comments

Comments
 (0)