Skip to content

Conversation

@Kxiru
Copy link
Contributor

@Kxiru Kxiru commented Nov 14, 2024

Done

  • /solutions/secure-open-source (Now /solutions/open-source-security) according to copydoc.
  • /solutions/ai/infrastructure edits to ensure consistency of links and terminology.
  • Meganav edits according to copydoc
  • Form file rename to maintain consistency in directory path change and phrasing.

Task link: https://warthogs.atlassian.net/browse/WD-16878?atlOrigin=eyJpIjoiNGI0NzM1NmEyMzA1NGRkODk2ZDg1YTk4NjJiMGJlODUiLCJwIjoiaiJ9

Copy Doc link: https://docs.google.com/document/d/1mrvhkrVjCCJE39h96CPG_b_ZHWVN0GHzZ_6TdoudeYs/edit?tab=t.0

Meganav Copy Doc link: https://docs.google.com/document/d/1Y0dxbuar0UAPSCfILtP7fsEX-83yDh7Ha637FA9Wbik/edit?disco=AAABYZ9jdNU

QA Page Link (ai/infrastructure): https://docs.google.com/document/d/1AtAApqxX9cbWf4a3cakEYbk7OoTfdBBi7FlA3WZz5ZM/edit

QA Page link:

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8002/
  • Run through the following QA steps
    ---> Verify Redirect link works
    ---> Verify that previous links have been amended. See QA Page link.

Issue / Card

Fixes urgent copydoc issues.

Screenshots

N/A

@Kxiru Kxiru requested review from akbarkz and petesfrench November 14, 2024 13:30
@Kxiru Kxiru self-assigned this Nov 14, 2024
@webteam-app
Copy link

Copy link
Contributor

@akbarkz akbarkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a redirect from the old URL to the new one, as specified in the description of the task (can be done through redirects.yaml file).
Also, could you please add a link to the task, a copy doc and the page that needs QA to the description?
Thanks!

@Kxiru Kxiru force-pushed the update-secure-open-source branch 2 times, most recently from 625fa68 to 0d32032 Compare November 15, 2024 16:00
@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.82%. Comparing base (d0dae39) to head (0d32032).
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
+ Coverage   69.73%   69.82%   +0.09%     
==========================================
  Files          15       15              
  Lines        1229     1233       +4     
==========================================
+ Hits          857      861       +4     
  Misses        372      372              
Flag Coverage Δ
python 69.82% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nkeiruka <nkeiruka.whenu@canonical.com>
@Kxiru Kxiru force-pushed the update-secure-open-source branch from 0d32032 to 054ea9e Compare November 15, 2024 16:32
@Kxiru Kxiru requested a review from petesfrench November 15, 2024 16:34
@Kxiru Kxiru dismissed akbarkz’s stale review November 15, 2024 16:38

Addressed changes

@Kxiru Kxiru merged commit 26a78fe into main Nov 15, 2024
9 checks passed
@Kxiru Kxiru deleted the update-secure-open-source branch November 15, 2024 16:38
@Kxiru Kxiru restored the update-secure-open-source branch November 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants