add a check after all upgrades to check apt is in a healthy state #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersson1234
force-pushed
the
post-upgrade-apt-check
branch
from
ca93f62 to
4e851c4
Compare
julian-klode
reviewed
Sep 6, 2024
julian-klode
reviewed
Sep 6, 2024
andersson1234
force-pushed
the
post-upgrade-apt-check
branch
from
4e851c4 to
250b597
Compare
paride
reviewed
Sep 6, 2024
| post_tests | ||
| STATUS=$? | ||
| fi | ||
| check_no_apt_errors |
Collaborator
There was a problem hiding this comment.
I think we want to call this after every do-release-upgrade, in case we have more than one. So let's add it to do_upgrade_and_maybe_reboot(), after do_normal_upgrade().
andersson1234
force-pushed
the
post-upgrade-apt-check
branch
from
250b597 to
32c3b01
Compare
Contributor
Author
|
amended and ready for re-review |
Contributor
Author
|
Added a kernel check, not sure if implementation is okay, requires review |
julian-klode
suggested changes
Sep 6, 2024
Contributor
Author
|
I'm testing this PR now. |
This commit adds a check post upgrade. It's quite simple, it just runs: apt-get check Which, if exits non-zero, causes the upgrade job to fail. We don't want to consider an upgrade "all good" if it leaves apt in a broken state!
andersson1234
force-pushed
the
post-upgrade-apt-check
branch
from
a0005f7 to
1ed850e
Compare
Contributor
Author
|
This is now amended, tested, and ready for review. Please see example run (with extra debug logging) here: |
utkarsh2102
approved these changes
Sep 11, 2024
…l booted post-upgrade This check looks to catch errors, such as the ones we saw with jammy->noble upgrades: https://discourse.canonical.com/t/retrospective-on-jammy-noble-kernel-header-upgrade-issue/4263 Prior to upgrade, the upgrade script now stores the output of: dpkg -l linux-*-$kernel where $kernel=$(uname -r). Then, post upgrade, we check the output of the dpkg -l... command again. If it is the same - happy! If not, fail :'( This should mean that we spot upgrade issues related to kernels and kernel headers much quicker in the future.
andersson1234
force-pushed
the
post-upgrade-apt-check
branch
from
1ed850e to
59a2d00
Compare
Contributor
Author
|
implemented Julian's nit, I will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.