Add PostgreSQL index access method reflection support#19369
Open
dereuromark wants to merge 2 commits into5.nextfrom
Open
Add PostgreSQL index access method reflection support#19369dereuromark wants to merge 2 commits into5.nextfrom
dereuromark wants to merge 2 commits into5.nextfrom
Conversation
This adds the ability to reflect PostgreSQL index access methods (gin, gist, spgist, brin, hash) when describing indexes. Changes: - Add `accessMethod` property to Index class with constants for PostgreSQL access methods (GIN, GIST, SPGIST, BRIN, HASH) - Update describeIndexQuery() to join pg_am and fetch amname - Update describeIndexes() and convertIndexDescription() to include accessMethod in result for non-btree indexes - Update indexSql() to generate USING clause for non-btree indexes This enables migrations to properly reflect and regenerate indexes that use specialized PostgreSQL access methods. Refs cakephp/migrations#1053
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the ability to reflect PostgreSQL index access methods (gin, gist, spgist, brin, hash) when describing indexes.
Changes:
accessMethodproperty toIndexclass with constants for PostgreSQL access methods (GIN,GIST,SPGIST,BRIN,HASH)describeIndexQuery()to joinpg_amand fetchamnamedescribeIndexes()andconvertIndexDescription()to includeaccessMethodin result for non-btree indexesindexSql()to generateUSINGclause for non-btree indexesWhy:
This enables migrations (cakephp/migrations#1053) to properly reflect and regenerate indexes that use specialized PostgreSQL access methods. Without reflection support, snapshot generation would be lossy - indexes created with GIN/GIST/etc would be reflected as standard btree indexes.
Usage
When an index uses a non-btree access method, the reflected index data will include the
accessMethodfield:The
Indexclass now includes constants for PostgreSQL access methods:Refs cakephp/migrations#1053