Remove underscore prefix from property names in test files - #19332
Closed
dereuromark wants to merge 1 commit into
Closed
Remove underscore prefix from property names in test files#19332dereuromark wants to merge 1 commit into
dereuromark wants to merge 1 commit into
Conversation
This removes the underscore prefix from property names in test files to comply with CakePHP coding standards. The underscore prefix should not be used to indicate visibility in PHP. Properties renamed: - $_sessionBackup -> $sessionBackup - $_table -> $table (in test app tables) - $_hidden -> $hidden - $_virtual -> $virtual
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aims to be green in CI for cakephp/cakephp-codesniffer#424 then
Properties renamed:
$_sessionBackup->$sessionBackupin CacheSessionTest$_table->$tablein test app table files$_hidden->$hiddenin ProtectedUser entity$_virtual->$virtualin VirtualUser entityNote: The
$_toStringFormatproperties in I18n classes (Date, DateTime, Time) cannot be renamed as they intentionally use the underscore prefix to avoid type conflicts with parent Chronos classes.=> cakephp/chronos#497
Will be release with Chronos major in the future.