6.x: encourage constructor property promotion#19328
Open
Conversation
Contributor
Author
|
The test broke because the constructor-promotion refactor changed the internal property order of ConsoleInputOption, and ConsoleOptionParser was implicitly relying on that order via Before the refactor, ConsoleInputOptiondeclared its properties in the order: name, short, help, boolean, default, ... When ConsoleOptionParser.php did: PHP compared the ConsoleInputOption objects by their properties, so it effectively sorted by name first. That gave the old alphabetical order: connection, help, test. After the property-promotion change, ConsoleInputOption now has default declared first, and the promoted properties come after it. |
129eb2d to
7ccb686
Compare
7ccb686 to
951195f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid if