Final SIMD opcodes#222
Merged
yurydelendik merged 3 commits intobytecodealliance:mainfrom Feb 19, 2021
Merged
Conversation
- add and update i64x2 comparison ops - i8x16.popcnt - pairwise adds - change op codes
alexcrichton
approved these changes
Feb 9, 2021
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Looks good to me! This may need to blanket-ignore all wabt tests for the time being as well while we wait for it to update too.
Member
|
Ok looks like WebAssembly/simd#452 landed! Want to do a final sync with how the opcodes ended up and I can merge? |
Contributor
Author
|
crosslink to WebAssembly/simd#480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking WebAssembly/simd#452:
TODO: