add AI-generated unit cases for constant value#4789
add AI-generated unit cases for constant value#4789kylo5aby wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
kylo5aby
commented
Jan 16, 2026
kylo5aby
commented
- covers wasm_interp_call_func_bytecode, wasm_runtime_instantiate
- Line coverage: 32.7% → 32.9%
- Function coverage: no change
kylo5aby
requested review from
TianlongLiang,
lum1n0us and
yamt
as code owners
kylo5aby
force-pushed
the
unit-test-enhance-const
branch
3 times, most recently
from
9afdc45 to
7711ec4
Compare
Signed-off-by: zhenweijin <zhenwei.jin@intel.com> Co-authored-by: ai-assistant
kylo5aby
force-pushed
the
unit-test-enhance-const
branch
from
7711ec4 to
83e576e
Compare
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
Eventually, I think *fix.md, *review.md, and *verify.md should not be merged. They are process files.
We might need a file to inform future contributors (whether human or AI) about which functions and branches have not been covered, so they can add new cases. This would reduce the workload of analyzing and starting to add new cases.
It could also be a skill or some kind of script.
|
|
||
| if (WAMR_BUILD_TARGET STREQUAL "X86_64") | ||
| add_subdirectory(constants) | ||
| endif () |
There was a problem hiding this comment.
might need to reconsider. If all AI-generation cases are planned to adapt to x86-64 only, adding the if (WAMR_BUILD_TARGET STREQUAL "X86_64") control in tests/unit/CMakeLists.txt would be better.
diff --git a/tests/unit/CMakeLists.txt b/tests/unit/CMakeLists.txt
index 9c1a4a5d5..78312c62c 100644
--- a/tests/unit/CMakeLists.txt
+++ b/tests/unit/CMakeLists.txt
@@ -64,7 +64,9 @@ add_subdirectory(linux-perf)
add_subdirectory(gc)
add_subdirectory(tid-allocator)
add_subdirectory(unsupported-features)
-add_subdirectory(smart-tests)
+if(WAMR_BUILD_TARGET STREQUAL "X86_64")
+ add_subdirectory(smart-tests)
+endif()
if (NOT WAMR_BUILD_TARGET STREQUAL "X86_32")
add_subdirectory(aot-stack-frame)|
|
||
| ::testing::InitGoogleTest(&argc, argv); | ||
| return RUN_ALL_TESTS(); | ||
| } No newline at end of file |
| * @validation_method Verification that invalid operations return null/failure as expected | ||
| */ | ||
| TEST_P(I32ConstTest, ModuleLevelErrors_HandleGracefully) | ||
| { |
There was a problem hiding this comment.
This case seems not to belong here. It might need to be removed.
| * @expected_behavior Proper error handling without crashes, returns null on invalid input | ||
| * @validation_method Verification that invalid operations return null/failure as expected | ||
| */ | ||
| TEST_P(I32ConstTest, ModuleLevelErrors_HandleGracefully) |
There was a problem hiding this comment.
This case seems not to belong here. It might need to be removed.
lum1n0us
added
the
ai-assistant
2 participants
