Move exception lock to ModuleInstance data.#4772
Open
vchigrin wants to merge 1 commit intobytecodealliance:mainfrom
Open
Move exception lock to ModuleInstance data.#4772vchigrin wants to merge 1 commit intobytecodealliance:mainfrom
vchigrin wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
This lock acquired on each native function call. This cause performance impact on programs, containing many native function calls, and running in multithreaded environment.
vchigrin
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi and
yamt
as code owners
lum1n0us
added
the
bug-fix
lum1n0us
added
the
breaking-change
lum1n0us
requested changes
Feb 3, 2026
Contributor
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
-
The PR has affected the layout of
WASMModuleInstanceExtra, which will change keyoffsetofvalues in AOT files. Therefore, it requires a newAOT_CURRENT_VERSIONin core/config.h. -
Obviously, there is a failed CI that should be fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lock acquired on each native function call. This cause performance impact on programs, containing many native function calls, and running in multithreaded environment.