add a set of apis to configure wasi-nn via InstantiationArgs2#4764
Open
zhanheng1 wants to merge 26 commits intobytecodealliance:mainfrom
Open
add a set of apis to configure wasi-nn via InstantiationArgs2#4764zhanheng1 wants to merge 26 commits intobytecodealliance:mainfrom
zhanheng1 wants to merge 26 commits intobytecodealliance:mainfrom
Conversation
zhanheng1
force-pushed
the
InstantiationArgs2-wasinn
branch
from
77794ae to
c73e4aa
Compare
zhanheng1
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi and
yamt
as code owners
yamt
reviewed
Jan 21, 2026
yamt
reviewed
Feb 5, 2026
| #include "wasi_nn.h" | ||
|
|
||
| #undef WASM_ENABLE_WASI_EPHEMERAL_NN | ||
| #undef WASI_NN_NAME |
Contributor
Author
There was a problem hiding this comment.
In wasi_ephemeral_nn.h, macros are defined and then wasi_nn.h is included immediately after, but these macro definitions are later undefined (#undef). This means that in utils.h, the macros might be in an undefined state, leading to compilation errors( if WASM_ENABLE_WASI_EPHEMERAL_NN != 0).
| "through --wasi-nn-graph", | ||
| nul_terminated_name); | ||
| res = not_found; | ||
| } |
Contributor
There was a problem hiding this comment.
i suppose wasi_nn_load_by_name_with_config needs an equivalent.
i guess it's simpler to make them share a common logic.
… named WASINNRegistry. Replace malloc/free to wasm_runtime_malloc/_free, replace strdup to bh_strdup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a set of apis to configure wasi-nn via InstantiationArgs2: