Expose WAMR_BUILD_GC_HEAP_SIZE_DEFAULT as a CMake option#4124
Merged
lum1n0us merged 4 commits intobytecodealliance:mainfrom Mar 12, 2025
Merged
Expose WAMR_BUILD_GC_HEAP_SIZE_DEFAULT as a CMake option#4124lum1n0us merged 4 commits intobytecodealliance:mainfrom
lum1n0us merged 4 commits intobytecodealliance:mainfrom
Conversation
This is wired through to the GC_HEAP_SIZE_DEFAULT constant. Also honor this value when configuring the engine with the wasm_c_api.
swankjesse
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
Author
|
Alternately, it’d be great to expose the gc_heap_size as option in |
lum1n0us
requested changes
Mar 3, 2025
swankjesse
commented
Mar 4, 2025
swankjesse
force-pushed
the
WAMR_BUILD_GC_HEAP_SIZE_DEFAULT
branch
from
bb949f9 to
d609acf
Compare
swankjesse
force-pushed
the
WAMR_BUILD_GC_HEAP_SIZE_DEFAULT
branch
from
578ee38 to
9027b2d
Compare
no1wudi
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is wired through to the GC_HEAP_SIZE_DEFAULT constant.
Also honor this value when configuring the engine with the wasm_c_api.