Add support for the Component Model Async ABI#37
Merged
dicej merged 4 commits intobytecodealliance:mainfrom Oct 8, 2024
Merged
Add support for the Component Model Async ABI#37dicej merged 4 commits intobytecodealliance:mainfrom
dicej merged 4 commits intobytecodealliance:mainfrom
Conversation
Add support for the Component Model [Async ABI](https://github.com/WebAssembly/component-model/blob/main/design/mvp/Async.md) to `wasm-tools`, `wit-bindgen`, and `wasmtime`. [Rendered RFC](https://github.com/dicej/rfcs/blob/component-async/accepted/component-model-async.md) Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Member
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Hooray! 🥳
From a brief skim, the parts of this that I'm qualified to have an opinion on all look good to me. I left a couple of inline comments on specific aspects, but they're not particularly important.
- Simplify `AsyncConfig` for the guest binding generator - Focus on API and implementation topics in the `Rationale and alternatives` section Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Contributor
Author
|
Ugh, I definitely did not mean to merge this. I must have pushed to origin/main by mistake. Sorry; will revert. |
Contributor
Author
|
I've reverted all the earlier commits, rebased, and opened #38 -- please direct further discussion there. Sorry again for the confusion! BTW, would it make sense to tweak the branch protection rules in this repo to block pushing straight to main? Asking for a friend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the Component Model Async ABI to
wasm-tools,wit-bindgen, andwasmtime.Rendered RFC