feat: enhance query history#20554
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Handle query-history route changes
When a query-history URL is navigated to while SQLEditorRouteShell is already mounted (for example via an in-app router navigation to /sql-editor/projects/.../queryHistories/...), this new prepareQueryHistory branch is only reached from the mount-only bootstrap effect above. The route changes but no history is fetched and no draft tab is opened; the later URL-sync effect can then replace the deep link with the currently selected tab route. Add route-change handling for this module or otherwise force this preparation to run for query-history navigations after initial mount.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Escape the fingerprint delimiter
This template literal embeds two literal NUL bytes in the .tsx source, which makes Git and other text-processing tools classify SQLEditorRouteShell.tsx as binary (the commit diff for this file is already hidden as Bin ...). That makes future reviews, patches, and some scanners brittle; use an escaped delimiter such as \u0000 (or a structured key) so the source stays a normal text file while preserving the fingerprint behavior.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0932b05979
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
3 participants
Uh oh!
There was an error while loading. Please reload this page.