fix(sql-editor): show correct row data in detail panel when results are sorted#19252
Merged
fix(sql-editor): show correct row data in detail panel when results are sorted#19252
Conversation
…re sorted When query results are sorted, double-clicking a cell to view details showed data from the wrong row. The detail panel was using the display position index to look up data in the original unsorted result array. Add originalRowIndex prop to TableCell to pass the original row index separately from the display position, ensuring the detail panel always shows the correct row data regardless of sorting state. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ecmadao
approved these changes
Feb 6, 2026
Collaborator
|
/backport |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
…re sorted (#19252) When query results are sorted, double-clicking a cell to view details showed data from the wrong row. The detail panel was using the display position index to look up data in the original unsorted result array. Add originalRowIndex prop to TableCell to pass the original row index separately from the display position, ensuring the detail panel always shows the correct row data regardless of sorting state. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> (cherry picked from commit 873a83e)
|
Successfully created backport PR for |
d-bytebase
pushed a commit
that referenced
this pull request
Feb 6, 2026
…re sorted (#19252) (#19253) When query results are sorted, double-clicking a cell to view details showed data from the wrong row. The detail panel was using the display position index to look up data in the original unsorted result array. Add originalRowIndex prop to TableCell to pass the original row index separately from the display position, ensuring the detail panel always shows the correct row data regardless of sorting state. (cherry picked from commit 873a83e) Co-authored-by: Vincent Huang <40749774+vsai12@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
originalRowIndexprop to TableCell to track the original row index separately from display positionrow.keyas the original indexProblem
When query results are sorted by clicking a column header, double-clicking a cell to view details showed data from the wrong row. The detail panel was using the display position index to look up data in the original unsorted result array.
Test plan
🤖 Generated with Claude Code