Add Customers resouce to Rubygem #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismaddern
force-pushed
the
chris/customers_api
branch
from
fd00575 to
72bd87b
Compare
chrismaddern
force-pushed
the
chris/customers_api
branch
from
72bd87b to
91d5c5f
Compare
griffinmyers
suggested changes
Mar 29, 2017
Contributor
griffinmyers
left a comment
griffinmyers
left a comment
There was a problem hiding this comment.
👏 This is awesome @chrismaddern!! Thanks for contributing : )
Let's call this 2.1.0 instead. When you make that change, we can merge. I'll then cut a release on Github and publish to rubygems.
CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| 3.0.0 March 29, 2017 | |||
Contributor
There was a problem hiding this comment.
I'd like to follow semver for this project. Could we make this v2.1.0 instead? This introduces new functionality in a backwards-compatible way.
Contributor
Author
There was a problem hiding this comment.
Good point @griffinmyers!
Will update now!
Contributor
Author
|
@griffinmyers Ready for review! Thanks for handling deploy 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.