Skip to content

Conversation

@mightyguava
Copy link
Contributor

No description provided.

@mightyguava mightyguava self-assigned this Nov 6, 2017
Copy link
Contributor

@griffinmyers griffinmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting!

A couple things:

  1. Please add tests to cover new functionality.
  2. Please update README.md documenting the new method.

Copy link
Contributor

@griffinmyers griffinmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! After you merge I'll tag and release.

@mightyguava mightyguava merged commit 1e3bd70 into master Nov 6, 2017
@mightyguava mightyguava deleted the yunchi/btnref branch November 6, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants