Include http response in errors; v2.4.0. #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griffinmyers
approved these changes
Jun 12, 2017
Contributor
griffinmyers
left a comment
griffinmyers
left a comment
There was a problem hiding this comment.
This is great. Thanks @mikeybtn.
Would you mind dropping a quick note in the README about the err object so people are aware?
I imagine returning response as a key on the result will also be handy someday.
| var response = JSON.parse(rawResponse); | ||
| } catch (e) { | ||
| return callback(new Error('Error parsing response as JSON: ' + rawResponse), null); | ||
| return callback( |
Contributor
There was a problem hiding this comment.
style nit: drop null and the trailing ) onto new lines, like on line 75. Optional, because I haven't found an eslint rule for it yet!
Contributor
|
Also, happy to publish when you merge to master--let me know if you don't have the npm creds. |
Contributor
Author
|
@griffinmyers thanks, PTAL! |
!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.