Move Client @connection to its own, independent method

vierarb · vierarb · commit 9cc5ea0a4673 · 2018-12-21T18:36:47.000Z
diff --git a/lib/buffer/client.rb b/lib/buffer/client.rb
@@ -7,20 +7,23 @@ class Client
     include Link
     include Info
 
-    attr_accessor :access_token
+    attr_accessor :access_token, :connection
+
+    URL = 'https://api.bufferapp.com/1/'.freeze
 
     def initialize(access_token)
       @access_token = access_token
-      url = "https://api.bufferapp.com/1/"
-      @connection = Faraday.new(url: url) do |faraday|
-        faraday.request  :url_encoded
-        faraday.adapter  Faraday.default_adapter
+    end
+
+    def connection
+      @connection ||= Faraday.new(url: URL) do |faraday|
+        faraday.request :url_encoded
+        faraday.adapter Faraday.default_adapter
       end
     end
 
     def auth_query
       { access_token: @access_token }
     end
-
   end
 end
diff --git a/lib/buffer/core.rb b/lib/buffer/core.rb
@@ -9,7 +9,7 @@ module Core
 
       def get(path, options = {})
         options.merge!(auth_query)
-        response = @connection.get do |req|
+        response = connection.get do |req|
           req.url path.remove_leading_slash
           req.params = options
         end
@@ -20,7 +20,7 @@ def get(path, options = {})
       def post(path, options = {})
         params = merge_auth_token_and_query(options)
         params.merge!(options)
-        response = @connection.post do |req|
+        response = connection.post do |req|
           req.url path.remove_leading_slash
           req.headers['Content-Type'] = "application/x-www-form-urlencoded"
           req.body = options[:body]
diff --git a/spec/lib/buffer_spec.rb b/spec/lib/buffer_spec.rb
@@ -13,6 +13,12 @@
     end
   end
 
+  describe "#connection" do
+    it "assigns the connection instance variable" do
+      subject.connection.should eq(subject.instance_variable_get(:@connection))
+    end
+  end
+
   describe "#info" do
     before do
       stub_request(:get, "#{base_path}/info/configuration.json?access_token=some_token").
