Conversation
|
|
4 tasks
higebu
force-pushed
the
feat-ip-prefix
branch
from
426ae3c to
68e7f3a
Compare
higebu
force-pushed
the
feat-ip-prefix
branch
from
68e7f3a to
64ed2f1
Compare
Contributor
Author
|
Passed conformance tests with bufbuild/protovalidate#99. $ buf export ../protovalidate/proto/protovalidate --output src/main/resources
$ buf generate --template buf.gen.yaml src/main/resources
$ buf generate --template conformance/buf.gen.yaml -o conformance/ ../protovalidate/proto/protovalidate-testing
$ ./gradlew build
$ ./gradlew conformance:jar
$ protovalidate-conformance --strict_message ./conformance/conformance.sh
PASS (failed: 0, skipped: 0, passed: 1100, total: 1100) |
rodaine
added a commit
to bufbuild/protovalidate
that referenced
this pull request
Oct 30, 2023
- [x] protovalidate-go: bufbuild/protovalidate-go#53 - [x] protovalidate-cc: bufbuild/protovalidate-cc#45 (via @paina) - [x] protovalidate-java: bufbuild/protovalidate-java#39 - [x] protovalidate-python: bufbuild/protovalidate-python#78 --------- Co-authored-by: Chris Roche <github@rodaine.com>
4 tasks
pkwarren
reviewed
Oct 31, 2023
src/main/java/build/buf/protovalidate/internal/celext/CustomOverload.java
Outdated
Show resolved
Hide resolved
src/main/java/build/buf/protovalidate/internal/celext/CustomOverload.java
Outdated
Show resolved
Hide resolved
src/test/java/build/buf/protovalidate/internal/celext/CustomOverloadTest.java
Show resolved
Hide resolved
Member
|
It also looks like we need to run |
Contributor
Author
|
@pkwarren Thank you for your review! I've addressed all your feedback. |
pkwarren
reviewed
Nov 1, 2023
src/main/java/build/buf/protovalidate/internal/celext/CustomOverload.java
Outdated
Show resolved
Hide resolved
src/test/java/build/buf/protovalidate/internal/celext/CustomOverloadTest.java
Outdated
Show resolved
Hide resolved
pkwarren
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: bufbuild/protovalidate#99