Skip to content

Fix remote generation usage conflicts#13

Merged
buildbreaker merged 17 commits intomainfrom
achiu/fix-remote-generation-usage-conflicts
Aug 2, 2023
Merged

Fix remote generation usage conflicts#13
buildbreaker merged 17 commits intomainfrom
achiu/fix-remote-generation-usage-conflicts

Conversation

@buildbreaker
Copy link
Contributor

@buildbreaker buildbreaker commented Aug 1, 2023

Locally generating and packaging protovalidate protos in this repo.

Fixes: bufbuild/protovalidate#62

@@ -0,0 +1,107 @@
// Generated by the protocol buffer compiler. DO NOT EDIT!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please configure a .gitattributes file so that these are flagged as generated in follow ups: https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github

buildbreaker and others added 8 commits August 2, 2023 10:56
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
Copy link
Member

@pkwarren pkwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Proto sources' lack of options interferes with protoc codegen for Java under Bazel.

2 participants