Fix: Correct time since calculations for user registration #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty in non-UTC timezones
dcavins
reviewed
Jul 28, 2025
| ); | ||
| // Use site timezone if available (WP 5.3+), fallback to UTC. | ||
| if ( function_exists( 'wp_timezone' ) ) { | ||
| $dt = date_create( $r[ $date ], wp_timezone() ); |
Contributor
There was a problem hiding this comment.
In what ways does date_create() fail here? I see that you're checking for success on the next line. If it fails, would falling back to the legacy time parser work? It depends on what makes it fail, which is why I ask if you know. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where BuddyPress would display incorrect "time since" values (such as "registered sometime ago") for users in non-UTC timezones. The root cause was a mismatch between the timezone of stored registration/activity dates (site local time) and the "current time" used for comparison (UTC), leading to negative or inaccurate results.
Changes
bp_core_time_diff()to use the site’s timezone (viawp_timezone(), available since WP 5.3) when parsing MySQL datetime strings.Fixes: https://buddypress.trac.wordpress.org/ticket/9284