REST API related issues for signups and pending accounts #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatonascalves
commented
Oct 29, 2024
| * | ||
| * @return mixed | ||
| */ | ||
| function bp_rest_api_signup_disabled_feature_dispatch_error( $result, $server, $request ) { |
Member
Author
There was a problem hiding this comment.
Here I'm trying to be helpful to the user. Communicating they need to activate this feature for it to work. The default error message is not very helpful.
renatonascalves
commented
Oct 29, 2024
| } | ||
|
|
||
| // Is the email already in use in a signup? | ||
| if ( ! isset( $errors['in_use'] ) ) { |
Member
Author
There was a problem hiding this comment.
Multiple pending accounts can be registered with the same email address, but different usernames. That's a bug, IMO.
imath
approved these changes
Oct 31, 2024
Contributor
imath
left a comment
imath
left a comment
There was a problem hiding this comment.
@renatonascalves thanks for this huge work. I've tested the patch and it works as expected. Feel free to SVN commit it.
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Nov 3, 2024
We are improving how signups and pending accounts are handled in BuddyPress. - activation emails resend are blocked for one hour, by default; - emails are checked if they are already in use in a signup; - `signup` endpoint (https://developer.buddypress.org/bp-rest-api/reference/signup/) returns a useful error when feature is disabled; - `Signup::resend`: Added the ability to resend to a single ID, instead of an array of IDs. Props niftythree and imath. Closes buddypress/buddypress#396 See #9229 and #9145 Fixes #9137 git-svn-id: http://buddypress.svn.wordpress.org/trunk@14071 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
emaralive
pushed a commit
to emaralive/omt-buddypress-sync
that referenced
this pull request
Nov 2, 2025
We are improving how signups and pending accounts are handled in BuddyPress. - activation emails resend are blocked for one hour, by default; - emails are checked if they are already in use in a signup; - `signup` endpoint (https://developer.buddypress.org/bp-rest-api/reference/signup/) returns a useful error when feature is disabled; - `Signup::resend`: Added the ability to resend to a single ID, instead of an array of IDs. Props niftythree and imath. Closes buddypress/buddypress#396 See #9229 and #9145 Fixes #9137 git-svn-id: https://buddypress.svn.wordpress.org/trunk@14071 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
emaralive
pushed a commit
to emaralive/buddypress-sync
that referenced
this pull request
Nov 3, 2025
We are improving how signups and pending accounts are handled in BuddyPress. - activation emails resend are blocked for one hour, by default; - emails are checked if they are already in use in a signup; - `signup` endpoint (https://developer.buddypress.org/bp-rest-api/reference/signup/) returns a useful error when feature is disabled; - `Signup::resend`: Added the ability to resend to a single ID, instead of an array of IDs. Props niftythree and imath. Closes buddypress/buddypress#396 See #9229 and #9145 Fixes #9137 git-svn-id: https://buddypress.svn.wordpress.org/trunk@14071 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9137
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.