chore: migrate to gh actions #1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can try https://github.com/Yoast/PHPUnit-Polyfills to fix issues on older PHP versions |
|
Or we should consider drop old PHP version support |
|
we are talking about php 5.6/7.0/7.1 versions, which are currently ancient, i would definitely suggest making life easier by dropping them |
|
+1 for dropping support for older versions. |
|
@bshaffer any news? |
|
Okay I dropped support for One question though... why is this a priority to the people on this thread? This does not add support or compatibility, it only affects the test suite. So I'm confused how something could be reliant on any of the changes being made here. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.