converted symfony2 settings to symfony3. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed to reflect symfony3.3
request changed to qs.
changed references to symfony3.
maxailloud
reviewed
Jul 18, 2017
| @@ -1,9 +1,9 @@ | |||
| { | |||
| "name": "bshaffer/oauth2-server-bundle", | |||
| "name": "alpha1125/oauth2-server-bundle", | |||
There was a problem hiding this comment.
Not sure this is something expected.
There was a problem hiding this comment.
you are right, it should not be expected. That should not be in there... "bshaffer" would be the correct one. Accidentally committed back in from testing... how do I revert that.
There was a problem hiding this comment.
You just do a new commit to revert that, and push it in your branch and the PR will be updated accordingly.
Added "request" object to be passed to twig.
paste blunder fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made superficial changes, to get the bundle to work in Symfony 3.3.4.