Merge pull request TheAlgorithms#472 from christianbender/changed_GCD_JAVA

Christian Bender · web-flow · commit 550984a6ff6f · 2018-07-25T17:08:16.000+02:00
fixed bug in method gcd(int, int)
diff --git a/Others/GCD.java b/Others/GCD.java
@@ -2,29 +2,37 @@
 //This is Euclid's algorithm which is used to find the greatest common denominator
 //Overide function name gcd
 
-public class GCD{
-
-      public static int gcd(int num1, int num2) {
-	
-        int gcdValue = num1 % num2;
-        while (gcdValue != 0) {
-            num2 = gcdValue;
-            gcdValue = num2 % gcdValue;
+public class GCD {
+
+    public static int gcd(int num1, int num2) {
+
+        if (num1 == 0)
+            return num2;
+
+        while (num2 != 0) {
+            if (num1 > num2)
+                num1 -= num2;
+            else
+                num2 -= num1;
         }
-        return num2;
+
+        return num1;
     }
-	public static int gcd(int[] number) {
-		  int result = number[0];
-		  for(int i = 1; i < number.length; i++) 
-			  //call gcd function (input two value)
-		          result = gcd(result, number[i]);
-		  
-		  return result;
-	}
-
-	public static void main(String[] args) {
-		int[] myIntArray = {4,16,32};
-		//call gcd function (input array)
-                System.out.println(gcd(myIntArray));
+
+    public static int gcd(int[] number) {
+        int result = number[0];
+        for (int i = 1; i < number.length; i++)
+            // call gcd function (input two value)
+            result = gcd(result, number[i]);
+
+        return result;
+    }
+
+    public static void main(String[] args) {
+        int[] myIntArray = { 4, 16, 32 };
+        
+        // call gcd function (input array)
+        System.out.println(gcd(myIntArray)); // => 4
+        System.out.printf("gcd(40,24)=%d gcd(24,40)=%d\n", gcd(40, 24), gcd(24, 40)); // => 8
     }
 }
