fix(a11y): restore per-command auto-scanning for App Automate a11y sessions#73
Open
AakashHotchandani wants to merge 3 commits into
Open
fix(a11y): restore per-command auto-scanning for App Automate a11y sessions#73AakashHotchandani wants to merge 3 commits into
AakashHotchandani wants to merge 3 commits into
Conversation
…ssions App Automate accessibility sessions were excluded from the per-command overwriteCommand wrapping in onBeforeExecute (guarded to !isAppAccessibility), so app a11y scans only fired via an explicit performScan() or the end-of-test lifecycle scan. Wrap commands for app sessions too, guarding each overwriteCommand individually so a command the appium driver does not register is skipped (debug-logged) instead of aborting onBeforeExecute. Commands appium registers (click, setValue, ...) now auto-scan on App Automate, matching the web flow. Updates the SDK-3813 tests that asserted overwriteCommand was skipped for app. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kamal-kaur04
previously approved these changes
Jul 24, 2026
xxshubhamxx
previously approved these changes
Jul 24, 2026
github-actions
Bot
dismissed stale reviews from kamal-kaur04 and xxshubhamxx
via
July 24, 2026 15:03
1a973e9
xxshubhamxx
approved these changes
Jul 24, 2026
Contributor
|
How to get (and keep) the
|
dandonarahul2002
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
App Automate accessibility sessions were excluded from the per-command
overwriteCommandwrapping inonBeforeExecute— the wrap was guarded to!this.isAppAccessibility(added by the SDK-3813 routing fix). The intent was to avoidoverwriteCommandthrowing on commands the appium driver doesn't register. But the side effect was that per-command auto-scanning was disabled entirely for App Automate — app a11y scans could only fire via an explicitbrowser.performScan()or the end-of-test lifecycle scan, unlike web sessions which auto-scan on every wrapped DOM command.This restores per-command auto-scanning for app while keeping the safety the guard was trying to provide:
!isAppAccessibilitycondition).overwriteCommandcall is wrapped in its owntry/catch, so a command the appium driver doesn't register is skipped (debug-logged) instead of aborting the whole wrap loop /onBeforeExecute.click,setValue, …) now auto-scan on App Automate, matching the web flow.Evidence
Empirically verified on prod: the pre-regression release (
@wdio/browserstack-service@9.29.1, before this routing change) auto-scanned app DOM commands (click,addValue) with no manualperformScan(). A build with this fix reproduced that per-command auto-scan on App Automate. The prior blanket-skip is what removed it; this change brings it back without the abort risk.Tests
Updated the SDK-3813 unit tests (which asserted
overwriteCommandwas skipped for app) to assert app sessions now wrap, and that an individual command wrap throwing does not abortonBeforeExecute. All 26accessibilityModuletests pass locally.Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
🤖 Generated with Claude Code