fix: correct SEA binary setup instructions - #360
Open
abhinavkr26104 wants to merge 1 commit into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Dev as Developer
participant App as Stagehand App
participant Resolver as resolve_binary_path()
participant Env as Environment
participant FS as File System
participant Docs as Documentation
Note over Dev, Docs: SEA Binary Resolution Flow with Corrected Guidance
Dev->>App: Run stagehand code
App->>Resolver: Call resolve_binary_path()
Resolver->>Env: Check STAGEHAND_SEA_BINARY
alt Environment variable set
Env-->>Resolver: Custom binary path
Resolver->>FS: Use custom binary
FS-->>Resolver: Binary exists
Resolver-->>App: Return binary path
else No environment variable
Env-->>Resolver: Not set
Resolver->>FS: Look for default SEA binary
FS-->>Resolver: File not found
Note over Resolver, Docs: Error path with corrected instructions
Resolver->>Resolver: Construct FileNotFoundError
Resolver-->>Dev: Raise error with guidance
Note over Dev, Docs: Error message contains corrected details
Dev->>Docs: Read error message
Docs-->>Dev: Instructions to run download script
Dev->>Dev: Run "uv run python scripts/download_binary.py"
Dev->>FS: Download SEA binary
FS-->>Dev: Binary available
Dev->>App: Retry stagehand code
end
Note over Dev, Resolver: Regression test validates error message content
Dev->>Resolver: Test with missing binary
Resolver-->>Dev: Verify correct script name and CONTRIBUTING.md link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/download_binary.pyhelperCONTRIBUTING.mdTesting
uv run --frozen pytest tests/test_sea_binary.py -q(5 passed)uv run --frozen ruff check .uv run --frozen pyright -p .uv run --frozen mypy --platform linux .Fixes #353
Summary by cubic
Corrects SEA missing-binary error guidance so local development instructions are accurate. Previously the error pointed to a non-existent script and a stale README anchor; it now references the correct helper script and
CONTRIBUTING.md. No behavior change beyond error text.https://github.com/browserbase/stagehand-python/blob/main/CONTRIBUTING.md.Fixes #353.
Written for commit a25a20e. Summary will update on new commits.