test: make suite deterministic on Windows - #189
Open
abhinavkr26104 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Windows treats environment variable names case-insensitively, so deleting lowercase
https_proxyafter setting uppercaseHTTPS_PROXYremoved the test value. Normal Git line-ending conversion also changes the fixture bytes from LF to CRLF, while the assertion hard-coded only the LF encoding.Fixes #181
Testing
python -m ruff check .python -m ruff format --check tests/test_client.py tests/test_transform.pypython -m pyright tests/test_client.py tests/test_transform.pyKnown unrelated baselines: repository-wide Ruff format reports two existing example files, and Python 3.12 mypy reports the
TypeAliasTypeissue fixed separately by #186.