fix: surface unexpected extension API success - #188
Open
abhinavkr26104 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APIStatusErrorWhy
The example previously raised
AssertionErrorinsidetryblocks guarded byexcept Exception, so its own failure assertions were immediately swallowed and printed as successful deletion checks.Fixes #180
Testing
python -m pytest tests/test_playwright_extensions.py -q(3 passed)python -m mypy examples/playwright_extensions.py tests/test_playwright_extensions.pypython -m pyright tests/test_playwright_extensions.pypython -m ruff check examples/playwright_extensions.py tests/test_playwright_extensions.pypython -m ruff format --check examples/playwright_extensions.py tests/test_playwright_extensions.pyThe live Browserbase E2E path requires project credentials and was not run locally; its control flow is covered with deterministic unit tests.