Skip to content

fix: support both TypeAliasType implementations #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinavkr26104 wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

fix: support both TypeAliasType implementations #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browserbase/_utils/_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def is_typevar(typ: type) -> bool:
return type(typ) == TypeVar # type: ignore


_TYPE_ALIAS_TYPES: tuple[type[typing_extensions.TypeAliasType], ...] = (typing_extensions.TypeAliasType,)
_TYPE_ALIAS_TYPES: tuple[type[object], ...] = (typing_extensions.TypeAliasType,)
if sys.version_info >= (3, 12):
_TYPE_ALIAS_TYPES = (*_TYPE_ALIAS_TYPES, typing.TypeAliasType)

Expand Down
20 changes: 19 additions & 1 deletion tests/test_utils/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
from __future__ import annotations

import sys
import typing
import typing_extensions
from typing import Generic, TypeVar, cast

from browserbase._utils import extract_type_var_from_base
from browserbase._utils import is_type_alias_type, extract_type_var_from_base

_T = TypeVar("_T")
_T2 = TypeVar("_T2")
_T3 = TypeVar("_T3")
ExtensionsAlias = typing_extensions.TypeAliasType("ExtensionsAlias", str)

if sys.version_info >= (3, 12):
StdlibAlias = typing.TypeAliasType("StdlibAlias", str)


class BaseGeneric(Generic[_T]): ...
Expand All @@ -24,6 +31,17 @@ class SubclassGenericMultipleTypeArgs(BaseGenericMultipleTypeArgs[_T, _T2, _T3])
class SubclassDifferentOrderGenericMultipleTypeArgs(BaseGenericMultipleTypeArgs[_T2, _T, _T3]): ...


def test_is_type_alias_type_from_typing_extensions() -> None:
assert is_type_alias_type(ExtensionsAlias)
assert not is_type_alias_type(str)


if sys.version_info >= (3, 12):

def test_is_type_alias_type_from_typing() -> None:
assert is_type_alias_type(StdlibAlias)


def test_extract_type_var() -> None:
assert (
extract_type_var_from_base(
Expand Down