Skip to content

docs: fix README Python examples - #184

Open
abhinavkr26104 wants to merge 1 commit into
browserbase:mainfrom
abhinavkr26104:fix/issue-176-readme-examples
Open

docs: fix README Python examples#184
abhinavkr26104 wants to merge 1 commit into
browserbase:mainfrom
abhinavkr26104:fix/issue-176-readme-examples

Conversation

@abhinavkr26104

Copy link
Copy Markdown

Summary

  • keep the complete Playwright quickstart inside one Python code fence
  • import httpx in the timeout example that uses httpx.Timeout
  • add regression tests that compile both README snippets

Why

The quickstart fence ended before the run function, making the rendered example incomplete, and the timeout snippet referenced httpx without importing it.

Fixes #176

Testing

Note: the repository-wide Ruff format check still reports two pre-existing example files (examples/playwright_downloads.py and examples/playwright_proxy.py).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix malformed README quickstart fence and non-runnable timeout snippet

1 participant